fix(docker): don't COPY empty include/ dir (unblocks simplepool image build)#6
Merged
rsantacroce merged 1 commit intoJul 20, 2026
Conversation
The Dockerfile.simplepool build stage did 'COPY include/ ./include/', but include/ is an empty directory. Git can't track empty dirs, so it's absent in a fresh checkout (CI), and buildx failed with '"/include": not found'. No header lives in include/ (all are under src/), and the Makefile's -Iinclude search path tolerates the directory's absence, so the copy is simply dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
build_dockerworkflow'ssimplepoolimage leg fails at buildx:deploy/docker/Dockerfile.simplepoolrunsCOPY include/ ./include/, butinclude/is an empty directory. Git can't track empty dirs, so it exists on a local dev checkout but is absent in a fresh CI checkout — hence theCOPYfails. (The dashboard/payout legs are unaffected.)Fix
Drop the
COPY include/ ./include/line. Nothing depends on it:include/— all headers are undersrc/.-Iincludesearch path harmlessly tolerates a missing directory (it's not-Werror-gated by-Wmissing-include-dirs).A comment is added so the line isn't reintroduced.
Validation
This PR runs
build_dockerin build-only mode (PRs don't push), which exercises the fullsimplepoolimage build and should now go green. Merging tomainpublishesghcr.io/layertwo-labs/simplepool.Note: the "Node.js 20 is deprecated" lines in the failed run are non-fatal warnings (the actions are auto-run on Node 24), unrelated to this failure.